Add return type for executeAction #2907
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 2, 2023 20:52
|
kemal durmuş seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
mkemaldurmus
changed the title
mkemaldurmus
force-pushed
the
add-return-type
branch
from
f0e585b
to
0a6192b
Compare
mkemaldurmus
force-pushed
the
add-return-type
branch
from
0a6192b
to
00086ca
Compare
|
@mkemaldurmus Thanks for your work. |
mkemaldurmus
force-pushed
the
add-return-type
branch
2 times, most recently
from
d1040a6
to
99e3a4c
Compare
mkemaldurmus
force-pushed
the
add-return-type
branch
from
0545e0f
to
6ee4811
Compare
|
@guizmaii done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #issue_number
Problem
I've been using executeQuery when writing raw queries in Cassandra, but it uses the execute function, which means it operates synchronously. I want to use executeAction because it uses executeAsync. The problem is that executeAction returns Unit,
Solution
return AsyncResultSet instead of Unit
Notes
Additional notes.
Checklist
README.mdif applicable[WIP]to the pull request title if it's work in progresssbt scalariformFormat test:scalariformFormatto make sure that the source files are formatted@getquill/maintainers